Skip to content

Downgrade rust version to 1.86 as a temporary measure until we upgrade sp-io #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 20, 2025
Merged

Downgrade rust version to 1.86 as a temporary measure until we upgrade sp-io #1436

merged 11 commits into from
May 20, 2025

Conversation

ameba23
Copy link
Collaborator

@ameba23 ameba23 commented May 16, 2025 •
edited
Loading

See #1435

@ameba23
Copy link
Collaborator Author

ameba23 commented May 16, 2025 •
edited
Loading

It doesn't look like panic=abort made any difference - but locally it seemed to. 🤷

@ameba23 ameba23 changed the title Add panic = abort to runtime crate to see if it fixes #1435 Downgrade rust version in CI to see if it fixes #1435 May 16, 2025
HCastano
HCastano approved these changes May 19, 2025
View reviewed changes
Copy link
Collaborator

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI needs a few fixes, but from the other build artifact you handed off to SRE it does look like using 1.86.0 fixes the build

.github/actions/install-dependencies/action.yaml
@@ -12,6 +12,8 @@ runs:
shell: bash
- name: Add Rust components
run: |
rustup install 1.86.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a NOTE or FIXME comment here pointing to the build issue so we have a reference as to why we're on this particular version

rust-toolchain.toml Outdated
@@ -1,3 +1,3 @@
[toolchain]
channel="stable"
channel = "1.86.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here

@ameba23 ameba23 changed the title Downgrade rust version in CI to see if it fixes #1435 Downgrade rust version to 1.86 as a temporary measure until we upgrade sp-io May 19, 2025
@ameba23 ameba23 merged commit 731ae4b into master May 20, 2025
9 checks passed
@ameba23 ameba23 deleted the peg/try-fix-1435 branch May 20, 2025 07:22
ameba23 added a commit that referenced this pull request May 22, 2025
@ameba23
Merge branch 'master' into peg/avoid-reading-from-kvdb
0a8f079 
* master:
  Add attestation logic to Outtie pallet (#1431)
  Downgrade rust version to 1.86 as a temporary measure until we upgrade sp-io (#1436)
  Bump the patch-dependencies group across 1 directory with 3 updates (#1430)
  Add custom testnet chainspec inputs (#1424)
  Update release checklist with instructions to build CVM image for TDX (#1366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HCastano HCastano HCastano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ameba23 @HCastano